From cf2d2ee908e6e0a7c65d4f2fbdc82b90f55173b2 Mon Sep 17 00:00:00 2001
From: Paolo Brasolin <paolo.brasolin@eurac.edu>
Date: Thu, 24 Mar 2022 10:43:02 +0100
Subject: [PATCH] fix: #fe avoid texture key overlaps

---
 frontend/src/js/clue.ts | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/frontend/src/js/clue.ts b/frontend/src/js/clue.ts
index 3886cd4..01a552d 100644
--- a/frontend/src/js/clue.ts
+++ b/frontend/src/js/clue.ts
@@ -12,10 +12,11 @@ const DESCENDERS = /[AFHJPQYZÄfghjpqsyzß]/;
 class Clue extends Phaser.GameObjects.Sprite {
   word: Types.Word;
   scene: FightScene;
+  textureKey: string;
 
   constructor(scene: FightScene, word: Types.Word) {
     // TODO: set positions
-    super(scene, 400, 300, word.id);
+    super(scene, 400, 300, "__MISSING");
     scene.add.existing(this);
 
     this.setAlpha(0);
@@ -23,12 +24,14 @@ class Clue extends Phaser.GameObjects.Sprite {
     this.scene = scene;
     this.word = word;
 
+    // TODO: we could be smarter and fully leverage caching, but meh.
+    this.textureKey = `${word.id}-${Date.now()}`;
     this.loadTexture();
   }
 
   loadTexture() {
     // this.scene.textures.remove()
-    this.scene.textures.addBase64(this.word.id, this.word.image);
+    this.scene.textures.addBase64(this.textureKey, this.word.image);
     this.scene.textures.once(
       "addtexture",
       this.showTexture.bind(this),
@@ -45,7 +48,7 @@ class Clue extends Phaser.GameObjects.Sprite {
   }
 
   applyTexture() {
-    this.setTexture(this.word.id);
+    this.setTexture(this.textureKey);
     const scale =
       (this.estimateWordHeight() * BASE_HEIGHT) /
       this.texture.getSourceImage().height;
@@ -68,8 +71,8 @@ class Clue extends Phaser.GameObjects.Sprite {
 
   delete() {
     this.fadeOut(() => {
-      this.scene.textures.remove(this.texture); // TODO
-      this.destroy.bind(this);
+      this.texture.destroy();
+      this.destroy();
     });
   }
 
-- 
GitLab